On Feb 14, 2012, at 8:50 AM, Gregory Farnum wrote: > > You're right, those flags are only specified in ceph_fs.h. I don't > think it's appropriate to include that file in user-facing stuff as > it's mostly things that I'd consider to be Ceph internals, but the > CEPH_SETATTR_* stuff is obviously public since you need them for > ceph_setattr. My inclination would be to either move or duplicate them > into a header that's already installed, but I'm not sure which one is > best for that. Do you have any thoughts as a user? :) java-libcephfs has a build dependency on libcephfs-dev deb that only contains libcephfs.h. These flags must be available during build and it seems to make little sense to add another header just for these bits. So as far as moving vs copying I'm not sure, but exposing all of ceph_fs.h seems like overkill. Related: does Ceph re-use the POSIX bit masks for mode_t? -Noah-- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
