On Thu, 2011-12-29 at 04:11 -0500, Christoph Hellwig wrote: > On Wed, Dec 28, 2011 at 06:05:14PM -0800, Sage Weil wrote: > > From: Alex Elder <elder@xxxxxxxxxxxxx> > > > > The ceph code duplicates __d_find_any_alias(), but it currently > > does not take a reference to the returned dentry as it should. > > Replace the ceph implementation with an exact copy of what's > > found in "fs/dcache.c", and update the callers so they drop > > their reference when they're done with it. > > > > Unfortunately this requires the wholesale copy of the functions > > that implement __dget(). It would be much nicer to just export > > d_find_any_alias() from "fs/dcache.c" instead. > > Just exporting it would indeed be much better. Yes, that's the plan. We were originally hoping to get this into 3.2 and I figured it was too late in the cycle to be suggesting a (albeit pretty harmless) change to the dcache code. I will respin the patches. I'll wait an hour or two to see what Sage plans to do with these. -Alex -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
