On Tue, Oct 11, 2011 at 08:39:24AM -0700, Sage Weil wrote: > On Mon, 10 Oct 2011, Christoph Hellwig wrote: > > On Mon, Oct 10, 2011 at 09:19:43AM -0700, Sage Weil wrote: > > > Let me know if the below is clearer. The requirement is that ->d_prune be > > > called prior to unhashing (and then destroying) a victim dentry. I'm a > > > little worried about mixing that in with the lru helpers because it is > > > only indirectly related to whether the dentry is on the LRU, and that may > > > confuse people. A cleaned up opencoded patch is here: > > > > > > https://github.com/NewDreamNetwork/ceph-client/commit/784a6aa6dc7baf2069c40988d79130dba17c7068 > > > > > > and the updated dentry_lru_prune() wrapper version is below. > > > > Long term what I really want is a helper for doing more of the real > > removal in single place. This is one step towards it, and the series > > from Dave is another. > > Ah, makes sense. > > Dave, is the revised patch more clear? Yeah, I kind of understand what it is doing now, and the comments will remind me when I start digging in this code again. Thanks. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
