Re: [PATCH] ceph: fix memory leak in async readpages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 28 Sep 2011, Sage Weil wrote:
> I'll send this upstream with the other patches so it'll hopefully make 
> 3.1...

Er, not really.. this'll go upstream during the next merge window, along 
with the readahead code.  :)

sage


> 
> Thanks!
> sage
> 
> 
> On Wed, 28 Sep 2011, David Flynn wrote:
> 
> > The finish_read callback introduced in 63c90314546c1cec1f220f6ab24ea
> > fails to release the page list allocated in start_read.
> > ---
> >  fs/ceph/addr.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> > index e06a322..4144caf 100644
> > --- a/fs/ceph/addr.c
> > +++ b/fs/ceph/addr.c
> > @@ -261,6 +261,7 @@ static void finish_read(struct ceph_osd_request *req, struct ceph_msg *msg)
> >  		unlock_page(page);
> >  		page_cache_release(page);
> >  	}
> > +	kfree(req->r_pages);
> >  }
> >  
> >  /*
> > -- 
> > 1.7.4.1
> > --
> > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux