Re: [PATCH] ceph_common.sh: Do not sudo to root unless needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tommi Virtanen wrote:
On Wed, Sep 14, 2011 at 08:09, Jim Schutt <jaschut@xxxxxxxxxx> wrote:
Using do_root_cmd() doesn't really need to sudo to root
if you're already root.

Commit 71dc75bdafe62a098c0493ad62f2d0d2a6ca7946 causes a regression:
when system "foo" has a sudoers config that requires a tty,
init-ceph now fails like this:
 sudo: sorry, you must have a tty to run sudo

when it is invoked by root with something like this:
  ssh foo /etc/init.d/init-ceph start

Signed-off-by: Jim Schutt <jaschut@xxxxxxxxxx>

Applied as d64237a6a555944d6d35676490bc4fb7c7db965d, thank you.

(It seems I screwed up the author field in the commit, sorry about
that. I don't want to force push just to fix that; Signed-off-by gives
you credit anyway.)



No problem - thanks for taking a look.

-- Jim


--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux