On Thu, Apr 21, 2011 at 10:35 AM, Colin McCabe <cmccabe@xxxxxxxxxxxxxx> wrote: > On Wed, Apr 20, 2011 at 10:03 PM, Sage Weil <sage@xxxxxxxxxxxx> wrote: >> >> The (re/ab)use of DIR* was possibly not the wisest choice in the original >> API (and Client.h for that matter?). Now might be the time to use a more >> reasonably named typedef. > > Looking at client/Client.cc, it seems to be using DIR* as a kind of > opaque pointer. Not a good call, because DIR is not opaque to anyone > who has included dirent.h. Hmm. Actually dirent does leave DIR* opaque. Anyway, we don't want people passing this pointer to readdir or something, so it ought to change. C. -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
