On Wed, Apr 20, 2011 at 10:03 PM, Sage Weil <sage@xxxxxxxxxxxx> wrote: > On Wed, 20 Apr 2011, Colin McCabe wrote: >> Hi guys, >> >> I pushed a branch with a revised libceph API. The main changes: >> >> * similar appearance to librados. It should be intuitive if you've >> used librados. >> * The new API allows multiple ceph clusters to be open at once >> (although the implementation doesn't support this yet) >> * ability to pass a "root" argument to ceph_mount >> * add support for reading configuration files and choosing whether to parse argv >> * simpler ceph_getcwd >> * unmount can't fail (the library always cleans up after itself) >> >> The branch is at >> http://ceph.newdream.net/git/?p=ceph.git;a=shortlog;h=refs/heads/libceph_api >> >> Let me know what you think! > > Can we combine the ceph_connect() and ceph_mount() into one thing? Does > that make sense? If so, maybe it should be ceph_mount_t and not > ceph_cluster_t or something. > > The (re/ab)use of DIR* was possibly not the wisest choice in the original > API (and Client.h for that matter?). Now might be the time to use a more > reasonably named typedef. > > A few of the methods can probably go away (things like ceph_mkdirs) or be > cleaned up (the layout get/set stuff). > > Otherwise looks good! Brian? > > sage > Looks good. The implicit state in the library seemed like a fairly good fit for the vfs stuff, but shouldn't be a problem to create, store, and pass that explicitly. I'm not certain what other libceph applications will require access to multiple ceph filesystems, but something like a replication program comes to mind most immediately. -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
