On Thursday, April 7, 2011 at 5:21 PM, Colin McCabe wrote: > I'm also aware that injectargs changes configuration values that other > threads may be reading, without using a lock or an atomic update. So > far, this doesn't seem to have created any problems, but it is > technically incorrect and a worry. Probably the best way to resolve > it is to construct a full copy of the configuration, change what is > required, and then do an atomic swap on the g_conf pointer. I don't think this *can* cause any problems. There are no other writers to g_conf and, while I don't think we have nested checks (ie, branch based on g_conf, then assume g_conf remains static inside branch), even if we did then our single-dispatch mechanism means we're not going to have concurrent updates of that stuff. :) -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
