Thanks, applied this one!
sage
On Tue, 29 Mar 2011, Dan Carpenter wrote:
> There was a missing unlock on the error path if __map_request() failed.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
> index b6776cb..03740e8 100644
> --- a/net/ceph/osd_client.c
> +++ b/net/ceph/osd_client.c
> @@ -1672,7 +1672,7 @@ int ceph_osdc_start_request(struct ceph_osd_client *osdc,
> if (req->r_sent == 0) {
> rc = __map_request(osdc, req);
> if (rc < 0)
> - return rc;
> + goto out_unlock;
> if (req->r_osd == NULL) {
> dout("send_request %p no up osds in pg\n", req);
> ceph_monc_request_next_osdmap(&osdc->client->monc);
> @@ -1689,6 +1689,8 @@ int ceph_osdc_start_request(struct ceph_osd_client *osdc,
> }
> }
> }
> +
> +out_unlock:
> mutex_unlock(&osdc->request_mutex);
> up_read(&osdc->map_sem);
> return rc;
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
