On Thursday, February 24, 2011 at 6:19 PM, Colin McCabe wrote: The branch, librados_api has been updated > via d15fe7f90bf488c6251be4633b104a822ebd134f (commit) > from e3f3177febf07bf3b311414167fdf4ccbf07c472 (commit) > > Those revisions listed above that are new to this repository have > not appeared on any other notification email; so we list those > revisions in full, below. > > http://ceph.newdream.net/git/?p=ceph.git;a=commit;h=d15fe7f90bf488c6251be4633b104a822ebd134f > > - Log ----------------------------------------------------------------- > commit d15fe7f90bf488c6251be4633b104a822ebd134f > Author: Colin Patrick McCabe <cmccabe@xxxxxxxxxxxxxx> > Date: Thu Feb 24 10:13:09 2011 -0800 > > rollback rename > > --- > > src/include/rados/librados.h | 4 ++-- > src/librados.cc | 5 ++--- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/src/include/rados/librados.h b/src/include/rados/librados.h > index d220cad..f63b58a 100644 > --- a/src/include/rados/librados.h > +++ b/src/include/rados/librados.h > @@ -120,8 +120,8 @@ void rados_objects_list_close(rados_list_ctx_t ctx); > /* snapshots */ > int rados_pool_snap_create(rados_pool_t pool, const char *snapname); > int rados_pool_snap_remove(rados_pool_t pool, const char *snapname); > -int rados_pool_snap_rollback_object(rados_pool_t pool, const char *oid, > - const char *snapname); > +int rados_rollback(rados_pool_t pool, const char *oid, > + const char *snapname); > void rados_pool_snap_set_read(rados_pool_t pool, rados_snap_t snap); > int rados_pool_selfmanaged_snap_create(rados_pool_t pool, uint64_t *snapid); > int rados_pool_selfmanaged_snap_remove(rados_pool_t pool, uint64_t snapid); > diff --git a/src/librados.cc b/src/librados.cc > index a819ebb..c1e81b2 100644 > --- a/src/librados.cc > +++ b/src/librados.cc > @@ -2674,9 +2674,8 @@ extern "C" int rados_pool_snap_remove(rados_pool_t pool, const char *snapname) > return ctx->client->snap_remove(ctx, snapname); > } > > -extern "C" int rados_pool_snap_rollback_object(rados_pool_t pool, > - const char *oid, > - const char *snapname) > +extern "C" int rados_rollback(rados_pool_t pool, const char *oid, > + const char *snapname) > { > RadosClient::PoolCtx *ctx = (RadosClient::PoolCtx *)pool; > return ctx->client->snap_rollback_object(ctx, oid, snapname); > _______________________________________________ > Ceph-commit mailing list > Ceph-commit@xxxxxxxxxxxxxxxxxxxxxxx > http://lists.ceph.newdream.net/listinfo.cgi/ceph-commit-ceph.newdream.net > I think you guys talked about this yesterday -- sorry I missed it -- but what's the logic behind this new name "rados_rollback"? It's not quite working for me -- I think because it lacks the noun. :) Could we at least do rados_object_rollback()? Or even rados_object_rollback_to_snap()? -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
