On Wed, Feb 23, 2011 at 1:58 PM, Colin Patrick McCabe <colin.mccabe@xxxxxxxxxxxxx> wrote: > > Questions: > * Do we even need g_conf.name any more? We could just call > g_conf.entity_name.to_str() and get the same thing. (Actually, a > better thing.) Yeah, we can either remove it completely or just set it to be the result of g_con.entity_name.to_str() > * Should we rename g_conf.type to g_conf.program_name? Program name is > a clear and unambiguous concept; what we have now is not useful. > * Should $type expand out to ceph_entity_type_name(g_conf.entity_name.type)? > In practice, this would bring us back to $type being "auth", "mon", > "osd", "mds", or "client", etc. again. This seems to be the original > intention of the system. I don't think we need g_conf.type anyway. > * Allowing users to set id is great. Allowing them to set the program > type seems wrong. Yet there is some evil code lurking in there that > parses the id parameter and tries to use it to set g_conf.type. > I don't see the point of preventing users from changing the type. It doesn't solve any security issue, and as long as they don't have a key to match the program type (when cephx is used) it won't help them much. Yehuda -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
