Re: librados api cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 18, 2011 at 1:36 PM, Sage Weil <sage@xxxxxxxxxxxx> wrote:
> [config example]

Looks good.

> const char *rados_conf_get(rados_t cluster, const char *option);

I would prefer something like
int rados_conf_get(rados_t cluster, const char *option, char **buf, int len);

We have a lot of configuration options that are ints and floats. You
can't really return a const char* pointer to an int-- you need to make
a temporary string somewhere, and that won't be const...

We should also provide some feature like "pass -1 as length, and we'll
malloc it for you."

> I think the (short term) trick will be supporting this immediately before
> the config refactoring is in place.  Should be possible with a hidden
> argv vector and the existing internal framework, I think.

Yeah, it should be do-able.

Colin
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux