Re: mkcephfs: clean up temp files, honor $TEMPDIR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 6, 2011 at 5:33 AM, DongJin Lee <dongjin.lee@xxxxxxxxxxxxxx> wrote:
> Hi all:
>
> commit 09c38e8edadb3a5bf470ff9b0409172e0c61e012
> About introducing the new tmp directory.
>
> TDIR=`mktemp -d -t mkcephfs.XXXXXXXXXX` || exit 1
> trap "rm -rf ${TDIR}; exit" INT TERM EXIT
>
> I think this works if running all on the same nodes.
> but other nodes don't know this directory name as they don't yet have
> this newly (and randomly) created directory.

Yes, the scp should be fixed. Good find.

> Also, in the line 193, scp -q $conf $host:$conf
> I don't think we check whether nodes have config directory, e.g., for
> -c /etc/ceph/ceph.conf, we don't check /etc/ceph directory?
> and so the other custom directory would also fail, too I think.

I suppose we should do a mkdir -p before copying over the configuration file.

cheers,
Colin
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux