Re: stripping of ceph class objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yehuda,

On Thu, 2010-12-16 at 15:35 -0800, Yehuda Sadeh Weinraub wrote:
>  we just installed the latest ceph debian packages and it seems that
> the class objects (that are installed in /usr/lib/rados-classes/) are
> stripped. [...] Our regular
> automake resulted binaries keeps those symbols, but I guess that the
> debian packaging strips them.
 Indeed, the packaging stripped them. The attached patch fixes this
issue. Also ceph.lintian should be ceph.lintian-overrides .
I'm a bit confused, why ceph should depend explicitly on binutils? I may
understand libedit2 as ceph build depends on its -dev counterpart; but I
couldn't find a binary that is linked with it.

Sage, is it OK if I commit this patch?

Cheers,
Laszlo/GCS
diff --git a/debian/ceph.lintian-overrides b/debian/ceph.lintian-overrides
index 6463e89..566fc33 100644
--- a/debian/ceph.lintian-overrides
+++ b/debian/ceph.lintian-overrides
@@ -1,4 +1,5 @@
 #
 # the rados classes should NOT be stripped.
 #
-ceph binary: unstripped-binary-or-object ./usr/lib/rados-classes/libcls_rbd.so.1.0.0
+ceph: unstripped-binary-or-object ./usr/lib/rados-classes/libcls_rbd.so.1.0.0
+
diff --git a/debian/control b/debian/control
index bc1247f..d3dc2bf 100644
--- a/debian/control
+++ b/debian/control
@@ -11,7 +11,7 @@ Standards-Version: 3.9.1
 
 Package: ceph
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, libedit2, hdparm, binutils
+Depends: ${shlibs:Depends}, ${misc:Depends}, hdparm
 Recommends: ceph-client-tools, ceph-fuse, libceph1, librados1, libcrush1, btrfs-tools
 Description: distributed storage and file system
  Ceph is a distributed storage and network file system designed to provide
diff --git a/debian/rules b/debian/rules
index 5b99834..1941750 100755
--- a/debian/rules
+++ b/debian/rules
@@ -61,14 +61,13 @@ binary-arch: build install
 	dh_lintian
 	dh_link
 
-	dh_strip -pceph --dbg-package=ceph-dbg
+	dh_strip -pceph --dbg-package=ceph-dbg -k --exclude=libcls_
 	dh_strip -pceph-fuse --dbg-package=ceph-fuse-dbg
 	dh_strip -pceph-client-tools --dbg-package=ceph-client-tools-dbg
 	dh_strip -plibcrush1 --dbg-package=libcrush1-dbg
 	dh_strip -plibrados1 --dbg-package=librados1-dbg
 	dh_strip -plibceph1 --dbg-package=libceph1-dbg
 	dh_strip -pradosgw --dbg-package=radosgw-dbg
-#	dh_strip -k --exclude=libcls_
 
 	dh_compress
 	dh_fixperms

[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux