Thanks, applied! sage On Sun, 17 Oct 2010, Julia Lawall wrote: > Convert a sequence of kmalloc and memcpy to use kmemdup. > > The semantic patch that performs this transformation is: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression a,flag,len; > expression arg,e1,e2; > statement S; > @@ > > a = > - \(kmalloc\|kzalloc\)(len,flag) > + kmemdup(arg,len,flag) > <... when != a > if (a == NULL || ...) S > ...> > - memcpy(a,arg,len+1); > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > fs/ceph/xattr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff -u -p a/fs/ceph/xattr.c b/fs/ceph/xattr.c > --- a/fs/ceph/xattr.c > +++ b/fs/ceph/xattr.c > @@ -716,10 +716,9 @@ int ceph_setxattr(struct dentry *dentry, > > /* preallocate memory for xattr name, value, index node */ > err = -ENOMEM; > - newname = kmalloc(name_len + 1, GFP_NOFS); > + newname = kmemdup(name, name_len + 1, GFP_NOFS); > if (!newname) > goto out; > - memcpy(newname, name, name_len + 1); > > if (val_len) { > newval = kmalloc(val_len + 1, GFP_NOFS); > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
