On Wed, Jul 14, 2010 at 6:35 AM, Christian Brunner <chb@xxxxxx> wrote:
>
> Hi Yehuda,
>
> this is an updated version of the patch I've sent yesterday. It is now based on the
> current rbd branch and it is using qemu_cond_* and qemu_mutex_*.
<snip>
>
> + while (s->queuesize > MAX_QUEUE_SIZE) {
> + qemu_mutex_lock(s->queue_mutex);
> + qemu_cond_wait(s->queue_threshold, s->queue_mutex);
> + qemu_mutex_unlock(s->queue_mutex);
> + }
Actually we shouldn't be waiting inside the aio handler. We should
probably be feeding the request into some wait queue and have a
separate thread that drains all those requests out. Though this
wouldn't help us in throttling the client memory, it's probably a more
correct way to handle the problem.
Yehuda
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
