On Tue, 6 Jul 2010, Miguel F Mascarenhas Sousa Filipe wrote:
> Hi there,
>
> I'm interested in this project and started now checking out the code
> and make it compile...
>
> I got hunting this signed comparison warning:
>
> mds/Locker.cc: In member function ÿÿbool
> Locker::_do_cap_update(CInode*, Capability*, int, snapid_t,
> MClientCaps*, MClientCaps*)ÿÿ:
> mds/Locker.cc:1923: warning: comparison between signed and unsigned
> integer expressions
>
> that is related with inode_t->get_layout_size_increment() being signed.
> This seems like a bug since it returns a size, but since I don't know
> the implications of changing this to uint64_t.. I'm asking..
>
> Is this the right fix?
It is, and has already been fixed in the unstable branch (for v0.21).
You're probably looking at the master branch or a earlier release
tarball..
Thanks!
sage
> --------
>
>
> diff --git a/src/mds/mdstypes.h b/src/mds/mdstypes.h
> index b7bfd1d..3054610 100644
> --- a/src/mds/mdstypes.h
> +++ b/src/mds/mdstypes.h
> @@ -379,7 +379,7 @@ struct inode_t {
>
> bool is_truncating() const { return (truncate_pending > 0); }
>
> - int64_t get_layout_size_increment() {
> + uint64_t get_layout_size_increment() {
> return layout.fl_object_size * layout.fl_stripe_count;
> }
>
> ------
>
> Kind regards,
>
> --
> Miguel Mascarenhas Filipe
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
