On Wed, May 05, 2010 at 09:40:47PM +0000, Sage Weil wrote: > > I think being able to specify a callback for each would be the most > flexible. Also, to be clear, setting adjusting the completions callback > is safe if it happens prior to the completion being used (before calling > aio_read or whatever). After that I don't think we should make any > promises. > > The patch below changes the API a bit. Since I think kvm-rbd is the only > aio callback user so far, I'm going to be lazy and skip any compat cruft > to maintain compatibility. Does this look okay? The patch is looking good and it makes using the callback even simpler. I will send a patch for qemu in a few minutes. Christian -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html