Re: forwarding packets to service in same host without using loopback network

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Thu, Apr 26, 2012 at 1:18 AM,  <m.roth@xxxxxxxxx> wrote:

> Are you a student?

I'm doing my graduate studies, so i'm a student :). But i'm studying
theoretical physics so that does
not count here :)

bottom line is i'm not a CS student. But i develop software :)

>
> I ask, because in both functions, the first thing I see is
>
>>       if (ph)
>>         {
>>           id = ntohl (ph->packet_id);
>>           printf ("hw_protocol=0x%04x hook=%u id=%u ",
>>             ntohs (ph->hw_protocol), ph->hook, id);
>>         }
>
> and you have *no* error handling if !ph. If this should never be true,
> then a) why is it in an if statement, and b) I will say, with 99.44%
> confidence, that it *will* be the case sometime, in a situation you
> haven't thought of.
>
> I'm at work, so I may get back to this after work.
>
>       mark

I should have set up some error code, and do some aborting. but I'm
still at prototyping stage.

-- 
-aft
_______________________________________________
CentOS mailing list
CentOS@xxxxxxxxxx
http://lists.centos.org/mailman/listinfo/centos



[Index of Archives]     [CentOS]     [CentOS Announce]     [CentOS Development]     [CentOS ARM Devel]     [CentOS Docs]     [CentOS Virtualization]     [Carrier Grade Linux]     [Linux Media]     [Asterisk]     [DCCP]     [Netdev]     [Xorg]     [Linux USB]
  Powered by Linux