On Thu, 2023-10-26 at 21:55 -0700, Kui-Feng Lee wrote: [...] > > The test will pass even without this change. > But, the test harness may complain by showing warnings. > You may see an additional warning message without this change. Understood, thank you for explanation. > > Regarding assertion: > > > > > + ASSERT_EQ(skel->bss->test_2_result, 7, "test_2_result"); > > > > Could you please leave a comment explaining why the value is 7? > > I don't understand what invokes 'test_2' but changing it to 8 > > forces test to fail, so something does call 'test_2' :) > > It is called by bpf_dummy_reg() in bpf_testmod.c. > I will add a comment here. Oh, sorry, I did not notice, thank you. [...]
