On Mon, Oct 23, 2023 at 3:41 PM Song Liu <song@xxxxxxxxxx> wrote: > > This helper will be used to check whether a kfunc arg points to const > string. Add a type check (PTR_TO_MAP_VALUE) in case the helper is > misused in the future. The commit log is cryptic. Without reading the patch first it makes little sense. Most reviewers read the commit log first and then proceed to look at the code. Please reword all commit logs in this set. 'This helper' should probably be 'The check_reg_const_str() helper'. The log should also say that the checking logic is refactored out of the existing code and addition of PTR_TO_MAP_VALUE check is the only difference.
