On 10/23, Magnus Karlsson wrote: > On Thu, 19 Oct 2023 at 19:49, Stanislav Fomichev <sdf@xxxxxxxxxx> wrote: > > > > This series implements initial TX metadata (offloads) for AF_XDP. > > See patch #2 for the main implementation and mlx5/stmmac ones for the > > example on how to consume the metadata on the device side. > > > > Starting with two types of offloads: > > - request TX timestamp (and write it back into the metadata area) > > - request TX checksum offload > > > > Changes since v3: > > - fix xsk_tx_metadata_ops kdoc (Song Yoong Siang) > > - add missing xsk_tx_metadata_to_compl for XDP_SOCKETS=n (Vinicius Costa Gomes and Intel bots) > > - add reference timestamps to the selftests + refactor existing ones (Jesper) > > > > v3: https://lore.kernel.org/bpf/20231003200522.1914523-1-sdf@xxxxxxxxxx/ > > Thanks for working on this Stanislav. I went through the patch set and > it looks good to me. You have addressed all the feedback that Maciej > and I had on a previous version. Just had some small things in two of > the patches. Apart from that, you are good to go and you can add my > ack to the next version. > > Acked-by: Magnus Karlsson <magnus.karlsson@xxxxxxxxx> > > Again, really appreciate all your work with this! Thank you! Appreciate the review and comments as well!
