On Tue, Oct 17, 2023 at 12:45:40PM +0000, Yafang Shao wrote: > +/** > + * task_cgroup_id_within_hierarchy - Acquires the associated cgroup of a task ^ doesn't match actual function name. > + * within a specific cgroup1 hierarchy. The cgroup1 hierarchy is identified by > + * its hierarchy ID. > + * @tsk: The target task > + * @hierarchy_id: The ID of a cgroup1 hierarchy > + * > + * On success, the cgroup is returned. On failure, ERR_PTR is returned. > + * We limit it to cgroup1 only. > + */ > +struct cgroup *task_get_cgroup1_within_hierarchy(struct task_struct *tsk, int hierarchy_id) Maybe we can just named it task_get_cgroup1()? Thanks. -- tejun