On Wed, 18 Oct 2023 05:13:44 -0400, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: > On Wed, Oct 18, 2023 at 04:57:21PM +0800, Xuan Zhuo wrote: > > On Wed, 18 Oct 2023 04:44:24 -0400, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: > > > On Wed, Oct 18, 2023 at 04:00:22PM +0800, Xuan Zhuo wrote: > > > > On Wed, 18 Oct 2023 03:59:03 -0400, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: > > > > > On Wed, Oct 18, 2023 at 03:53:00PM +0800, Xuan Zhuo wrote: > > > > > > Hi Michael, > > > > > > > > > > > > Do you think it's appropriate to push the first two patches of this patch set to > > > > > > linux 6.6? > > > > > > > > > > > > Thanks. > > > > > > > > > > I generally treat patchsets as a whole unless someone asks me to do > > > > > otherwise. Why do you want this? > > > > > > > > As we discussed, the patch set supporting AF_XDP will be push to net-next. > > > > But the two patchs belong to the vhost. > > > > > > > > So, if you think that is appropriate, I will post a new patchset(include the two > > > > patchs without virtio-net + AF_XDP) to vhost. I wish that can be merged to 6.6. > > > > > > Oh wait 6.6? Too late really, merge window has been closed for weeks. > > > > I mean as a fix. So I ask you do you think it is appropriate? > > Sure if there's a bugfix please post is separately - what issues do > these two patches fix? this is the part I'm missing. Especially patch 2 > which just adds a new API. No bugfix. That is the requirement of the supporting AF_XDP. So please ignore my question. Sorry ^_^. Thanks. > > > > > > > > Then when the 6.7 net-next merge window is open, I can push this patch set to 6.7. > > > > The v1 version use the virtqueue_dma_map_single_attrs to replace > > > > virtqueue_dma_map_page_attrs. But I think we should use virtqueue_dma_map_page_attrs. > > > > > > > > Thanks. > > > > > > > > > > Get a complete working patchset that causes no regressions posted first please > > > then we will discuss merge strategy. > > > I would maybe just put everything in one file for now, easier to merge, > > > refactor later when it's all upstream. But up to you. > > > > OK. I will get a working patchset firstly. > > > > Thanks. > > > > > > > > > > > > > > > > > > -- > > > > > MST > > > > > > > > >
