On Tue, 2023-10-17 at 16:59 +0100, Alan Maguire wrote: [...] > > Sorry for late response. > > > > This won't work if --btf_features_strict specifies an incomplete list, e.g.: > > > > $ pahole --btf_features_strict=decl_tag,enum64 --btf_encode_detached=/dev/null ~/work/tmp/test.o > > Feature in 'decl_tag,enum64' is not supported. 'pahole --supported_btf_features' shows the list of features supported. > > > > Also, I think it would be good to print exactly which feature is not supported. > > What do you think about modification as in the end of this email? > > (applied on top of your series). > > > > Argh, apologies, I could have sworn I'd tested this. No worries. > Thanks, the fix looks great, and I tested your modifications and all > looks good. I can add a Co-developed-by: tag for v3, or let me know > what attribution works best for you. I'll fix the cover letter as > per your other email also. Thanks for the help! > > Alan I don't think "Co-developed-by" is necessary, I can just add ack in the end. If you think that some attribution info is necessary for bookkeeping reasons maybe "Suggested-by"? Thanks, Eduard [...]
