On Tue, 17 Oct 2023 15:56:48 +0800 Yunsheng Lin wrote: > > And I can't figure out now what the "cache" in the name is referring to. > > Looks like these are just convenience wrappers which return VA instead > > of struct page.. > > Yes, it is corresponding to some API like napi_alloc_frag() returning va > instead of 'struct page' mentioned in patch 5. > > Anyway, naming is hard, any suggestion for a better naming is always > welcomed:) I'd just throw a _va (for virtual address) at the end. And not really mention it in the documentation. Plus the kdoc of the function should say that this is just a thin wrapper around other page pool APIs, and it's safe to mix it with other page pool APIs?