Hi Sebastian,
On 10/11/23 6:42 AM, John Fastabend wrote:
Sebastian Andrzej Siewior wrote:
A few drivers were missing a xdp_do_flush() invocation after
XDP_REDIRECT.
Add three helper functions each for one of the per-CPU lists. Return
true if the per-CPU list is non-empty and flush the list.
Add xdp_do_check_flushed() which invokes each helper functions and
creates a warning if one of the functions had a non-empty list.
Hide everything behind CONFIG_DEBUG_NET.
Suggested-by: Jesper Dangaard Brouer <hawk@xxxxxxxxxx>
Reviewed-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
LGTM.
Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>
Do you have a chance to send a v5 rebase? It does not apply to bpf-next.
Other than that, the patch lgtm.
Thanks,
Daniel