On Mon, Oct 9, 2023 at 10:31 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote: > > Hi Ian, > > On Mon, Oct 9, 2023 at 11:39 AM Ian Rogers <irogers@xxxxxxxxxx> wrote: > > > > Allow the clang-tools scripts to work with builds in tools such as > > tools/perf and tools/lib/perf. An example use looks like: > > > > ``` > > $ cd tools/perf > > $ make CC=clang CXX=clang++ > > $ ../../scripts/clang-tools/gen_compile_commands.py > > $ ../../scripts/clang-tools/run-clang-tools.py clang-tidy compile_commands.json -checks=-*,readability-named-parameter > > Skipping non-C file: 'tools/perf/bench/mem-memcpy-x86-64-asm.S' > > Skipping non-C file: 'tools/perf/bench/mem-memset-x86-64-asm.S' > > Skipping non-C file: 'tools/perf/arch/x86/tests/regs_load.S' > > 8 warnings generated. > > Suppressed 8 warnings (8 in non-user code). > > Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. > > 2 warnings generated. > > 4 warnings generated. > > Suppressed 4 warnings (4 in non-user code). > > Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. > > 2 warnings generated. > > 4 warnings generated. > > Suppressed 4 warnings (4 in non-user code). > > Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well. > > 3 warnings generated. > > tools/perf/util/parse-events-flex.c:546:27: warning: all parameters should be named in a function [readability-named-parameter] > > void *yyalloc ( yy_size_t , yyscan_t yyscanner ); > > ^ > > /*size*/ > > ... > > ``` > > > > Fix a number of the more serious low-hanging issues in perf found by > > clang-tidy. > > > > This support isn't complete, in particular it doesn't support output > > directories properly and so fails for tools/lib/bpf, tools/bpf/bpftool > > and if an output directory is used. > > > > v3. Add Nick Desaulniers reviewed-by to patch 3. For Namhyung, drop > > "perf hisi-ptt: Fix potential memory leak", split lock change out > > of "perf svghelper: Avoid memory leak" and address comments in > > "perf header: Fix various error path memory leaks". > > v2: Address comments by Nick Desaulniers in patch 3, and add their > > Reviewed-by to patches 1 and 2. > > > > Ian Rogers (18): > > gen_compile_commands: Allow the line prefix to still be cmd_ > > gen_compile_commands: Sort output compile commands by file name > > run-clang-tools: Add pass through checks and header-filter arguments > > perf bench uprobe: Fix potential use of memory after free > > perf buildid-cache: Fix use of uninitialized value > > perf env: Remove unnecessary NULL tests > > perf jitdump: Avoid memory leak > > perf mem-events: Avoid uninitialized read > > perf dlfilter: Be defensive against potential NULL dereference > > perf hists browser: Reorder variables to reduce padding > > perf hists browser: Avoid potential NULL dereference > > perf svghelper: Avoid memory leak > > perf lock: Fix a memory leak on an error path > > perf parse-events: Fix unlikely memory leak when cloning terms > > tools api: Avoid potential double free > > perf trace-event-info: Avoid passing NULL value to closedir > > perf header: Fix various error path memory leaks > > perf bpf_counter: Fix a few memory leaks > > I agree with your comment on v2 that it needs more work > to clean the code up. Anyway I'm ok with v3 now. > > For ther perf part (patch 4 to 18), > Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx> Applied to perf-tools-next, thanks!
