On Wed, Oct 11, 2023 at 03:37:25PM -0700, Andrii Nakryiko wrote: > Given missed_kprobe_recursion is non-serial and uses common testing > kfuncs to count number of recursion misses it's possible that some other > parallel test can trigger extraneous recursion misses. So we can't > expect exactly 1 miss. Relax conditions and expect at least one. > > Signed-off-by: Andrii Nakryiko <andrii@xxxxxxxxxx> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx> jirka > --- > tools/testing/selftests/bpf/prog_tests/missed.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/missed.c b/tools/testing/selftests/bpf/prog_tests/missed.c > index 24ade11f5c05..70d90c43537c 100644 > --- a/tools/testing/selftests/bpf/prog_tests/missed.c > +++ b/tools/testing/selftests/bpf/prog_tests/missed.c > @@ -81,10 +81,10 @@ static void test_missed_kprobe_recursion(void) > ASSERT_EQ(topts.retval, 0, "test_run"); > > ASSERT_EQ(get_missed_count(bpf_program__fd(skel->progs.test1)), 0, "test1_recursion_misses"); > - ASSERT_EQ(get_missed_count(bpf_program__fd(skel->progs.test2)), 1, "test2_recursion_misses"); > - ASSERT_EQ(get_missed_count(bpf_program__fd(skel->progs.test3)), 1, "test3_recursion_misses"); > - ASSERT_EQ(get_missed_count(bpf_program__fd(skel->progs.test4)), 1, "test4_recursion_misses"); > - ASSERT_EQ(get_missed_count(bpf_program__fd(skel->progs.test5)), 1, "test5_recursion_misses"); > + ASSERT_GE(get_missed_count(bpf_program__fd(skel->progs.test2)), 1, "test2_recursion_misses"); > + ASSERT_GE(get_missed_count(bpf_program__fd(skel->progs.test3)), 1, "test3_recursion_misses"); > + ASSERT_GE(get_missed_count(bpf_program__fd(skel->progs.test4)), 1, "test4_recursion_misses"); > + ASSERT_GE(get_missed_count(bpf_program__fd(skel->progs.test5)), 1, "test5_recursion_misses"); > > cleanup: > missed_kprobe_recursion__destroy(skel); > -- > 2.34.1 > >
