Hi, On 10/10/2023 12:56 AM, Alexei Starovoitov wrote: > On Sat, Oct 07, 2023 at 09:51:04PM +0800, Hou Tao wrote: >> From: Hou Tao <houtao1@xxxxxxxxxx> >> >> both syscall.c and helpers.c have the declaration of >> __bpf_obj_drop_impl(), so just move it to a common header file. >> >> Signed-off-by: Hou Tao <houtao1@xxxxxxxxxx> >> --- >> kernel/bpf/helpers.c | 3 +-- >> kernel/bpf/internal.h | 11 +++++++++++ >> kernel/bpf/syscall.c | 4 ++-- >> 3 files changed, 14 insertions(+), 4 deletions(-) >> create mode 100644 kernel/bpf/internal.h >> >> diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c >> index dd1c69ee3375..07f49f8831c0 100644 >> --- a/kernel/bpf/helpers.c >> +++ b/kernel/bpf/helpers.c >> @@ -24,6 +24,7 @@ >> #include <linux/bpf_mem_alloc.h> >> #include <linux/kasan.h> >> >> +#include "internal.h" > Pls use one of the existing headers. No need for new one. Do you mean one of header files in include/linux, right ? Because there is no proper header files under kernel/bpf. The best fit is include/linux/bpf.h, but after modify bpf.h, multiple files need to be rebuild: (e.g. under net/, kernel, drivers/net, block/, fs/). Maybe it is time to break bpf.h into multiple independent files ?
