On Tue, Oct 03, 2023 at 05:17:50PM -0700, Andrii Nakryiko wrote:
> We currently expect up to a three-digit number of tests and subtests, so:
>
> #999/999: some_test/some_subtest: ...
>
> Is the largest test/subtest we can see. If we happen to cross into
> 1000s, current logic will just truncate everything after 7th character.
> This patch fixes this truncate and allows to go way higher (up to 31
> characters in total). We still nicely align test numbers:
>
> #60/66 core_reloc_btfgen/type_based___incompat:OK
> #60/67 core_reloc_btfgen/type_based___fn_wrong_args:OK
> #60/68 core_reloc_btfgen/type_id:OK
> #60/69 core_reloc_btfgen/type_id___missing_targets:OK
> #60/70 core_reloc_btfgen/enumval:OK
>
> Signed-off-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
jirka
> ---
> tools/testing/selftests/bpf/test_progs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
> index 4d582cac2c09..1b9387890148 100644
> --- a/tools/testing/selftests/bpf/test_progs.c
> +++ b/tools/testing/selftests/bpf/test_progs.c
> @@ -255,7 +255,7 @@ static void print_subtest_name(int test_num, int subtest_num,
> const char *test_name, char *subtest_name,
> char *result)
> {
> - char test_num_str[TEST_NUM_WIDTH + 1];
> + char test_num_str[32];
>
> snprintf(test_num_str, sizeof(test_num_str), "%d/%d", test_num, subtest_num);
>
> --
> 2.34.1
>
>
