On Tue, Oct 03, 2023 at 03:49:20PM -0700, Jakub Kicinski wrote: > On Mon, 25 Sep 2023 10:19:57 -0700 Tony Nguyen wrote: > > Avoid stopping netdev tx queues during XSK setup by removing > > netif_tx_stop_queue() and netif_tx_start_queue(). > > These changes prevent unnecessary stopping and starting of netdev > > transmit queues during the setup of XDP socket. Without this change, > > after stopping the XDP traffic flow tracker and then stopping > > the XDP prog - NETDEV WATCHDOG transmit queue timed out appears. what is xdp traffic flow tracker? what do you mean by stopping xdp prog - or you removing it while keeping xsk pool present on interface? or are you just downing interface? can you provide steps to reproduce it? > > I think we need more info about what happens here. > > Maybe ice_qp_ena() fails before it gets to the start? > If we don't understand what happens, exactly, we may be papering > over other bugs. +1 > -- > pw-bot: cr >
