On 10/03, Larysa Zaremba wrote: > On Mon, Oct 02, 2023 at 09:46:08AM -0700, Stanislav Fomichev wrote: > > On Mon, Oct 2, 2023 at 9:35 AM Larysa Zaremba <larysa.zaremba@xxxxxxxxx> wrote: > > > > > > By default, xdp_hw_metadata runs in AF_XDP copy mode. However, hints are > > > also supposed to be supported in ZC mode, which is usually implemented > > > separately in driver, and so needs to be tested too. > > > > > > Add an option to run xdp_hw_metadata in ZC mode. > > > > > > As for now, xdp_hw_metadata accepts no options, so add simple option > > > parsing logic and a help message. > > > > > > For quick reference, also add an ingress packet generation command to the > > > help message. The command comes from [0]. > > > > > > [0] https://lore.kernel.org/all/20230119221536.3349901-18-sdf@xxxxxxxxxx/ > > > > I did similar changes in my pending [0], but I made the zerocopy, not > > the copy mode, the default. > > If you want to get this in faster (my series will probably need > > another iteration), let's maybe do the same here? > > ZC as a default feels better. > > > > 0: https://lore.kernel.org/bpf/20230914210452.2588884-9-sdf@xxxxxxxxxx/ > > I do not need those changes in tree ASAP, that is just something I had locally > for some time and decided to send. So I think I can wait for your series. This > way it is less work for both of us. SGTM, thanks!
