On 2023/09/28 1:02, KP Singh wrote: >> Question for KP Singh would be how can we allow dynamically appendable >> LSM modules if current linked list is replaced with static calls with >> minimal-sized array... > > As I suggested in the other thread: > > https://lore.kernel.org/bpf/20230918212459.1937798-1-kpsingh@xxxxxxxxxx/T/#md21b9d9cc769f39e451d20364857b693d3fcb587 > > You can add extra static call slots and fallback to a linked list > based implementation if you have more than say N modules [1] and > fallback to a linked list implementation [2]. As I explained in the other thread: https://lkml.kernel.org/r/c1683052-aa5a-e0d5-25ae-40316273ed1b@xxxxxxxxxxxxxxxxxxx build-time configuration does not help at all. > > for [1] you can just do MAX_LSM_COUNT you can just do: > > #ifdef CONFIG_MODULAR_LSM > #define MODULAR_LSM_ENABLED "1,1,1,1" > #endif > > and use it in the LSM_COUNT. > > for [2] you can choose to export a better module API than directly > exposing security_hook_heads. > > Now, comes the question of whether we need dynamically loaded LSMs, I > am not in favor of this. Please share your limitations of BPF as you > mentioned and what's missing to implement dynamic LSMs. My question > still remains unanswered. > > Until I hear the real limitations of using BPF, it's a NAK from me. Simple questions that TOMOYO/AKARI/CaitSith LSMs depend: Q1: How can the BPF allow allocating permanent memory (e.g. kmalloc()) that remains the lifetime of the kernel (e.g. before starting the global init process till the content of RAM is lost by stopping electric power supply) ? Q2: How can the BPF allow interacting with other process (e.g. inter process communication using read()/write()) which involves opening some file on the filesystem and sleeping for arbitrary duration? >> struct security_hook_heads security_hook_heads __ro_after_init; >> +EXPORT_SYMBOL_GPL(security_hook_heads); > > Rather than exposting security_hook_heads, this should actually export > security_hook_module_register. This should internally handle any data > structures used and also not need the special magic that you did for > __ro_after_init. I'm fine if security_hook_module_register() (and related code) cannot be disabled by the kernel configuration.
