Hi John, kernel test robot noticed the following build warnings: [auto build test WARNING on bpf/master] url: https://github.com/intel-lab-lkp/linux/commits/John-Fastabend/bpf-tcp_read_skb-needs-to-pop-skb-regardless-of-seq/20230926-042625 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master patch link: https://lore.kernel.org/r/20230925202448.100920-2-john.fastabend%40gmail.com patch subject: [PATCH bpf v2 1/3] bpf: tcp_read_skb needs to pop skb regardless of seq config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230926/202309260854.w4YOXCoL-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230926/202309260854.w4YOXCoL-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202309260854.w4YOXCoL-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): net/ipv4/tcp.c: In function 'tcp_read_skb': >> net/ipv4/tcp.c:1624:26: warning: unused variable 'tp' [-Wunused-variable] 1624 | struct tcp_sock *tp = tcp_sk(sk); | ^~ vim +/tp +1624 net/ipv4/tcp.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 1621 965b57b469a589 Cong Wang 2022-06-15 1622 int tcp_read_skb(struct sock *sk, skb_read_actor_t recv_actor) 04919bed948dc2 Cong Wang 2022-06-15 1623 { 04919bed948dc2 Cong Wang 2022-06-15 @1624 struct tcp_sock *tp = tcp_sk(sk); 04919bed948dc2 Cong Wang 2022-06-15 1625 struct sk_buff *skb; 04919bed948dc2 Cong Wang 2022-06-15 1626 int copied = 0; 04919bed948dc2 Cong Wang 2022-06-15 1627 04919bed948dc2 Cong Wang 2022-06-15 1628 if (sk->sk_state == TCP_LISTEN) 04919bed948dc2 Cong Wang 2022-06-15 1629 return -ENOTCONN; 04919bed948dc2 Cong Wang 2022-06-15 1630 44bb37a8112f62 John Fastabend 2023-09-25 1631 while ((skb = skb_peek(&sk->sk_receive_queue)) != NULL) { db4192a754ebd5 Cong Wang 2022-09-12 1632 u8 tcp_flags; db4192a754ebd5 Cong Wang 2022-09-12 1633 int used; 04919bed948dc2 Cong Wang 2022-06-15 1634 04919bed948dc2 Cong Wang 2022-06-15 1635 __skb_unlink(skb, &sk->sk_receive_queue); 96628951869c0d Peilin Ye 2022-09-08 1636 WARN_ON_ONCE(!skb_set_owner_sk_safe(skb, sk)); db4192a754ebd5 Cong Wang 2022-09-12 1637 tcp_flags = TCP_SKB_CB(skb)->tcp_flags; db4192a754ebd5 Cong Wang 2022-09-12 1638 used = recv_actor(sk, skb); db4192a754ebd5 Cong Wang 2022-09-12 1639 if (used < 0) { db4192a754ebd5 Cong Wang 2022-09-12 1640 if (!copied) db4192a754ebd5 Cong Wang 2022-09-12 1641 copied = used; db4192a754ebd5 Cong Wang 2022-09-12 1642 break; db4192a754ebd5 Cong Wang 2022-09-12 1643 } db4192a754ebd5 Cong Wang 2022-09-12 1644 copied += used; db4192a754ebd5 Cong Wang 2022-09-12 1645 44bb37a8112f62 John Fastabend 2023-09-25 1646 if (tcp_flags & TCPHDR_FIN) db4192a754ebd5 Cong Wang 2022-09-12 1647 break; db4192a754ebd5 Cong Wang 2022-09-12 1648 } 04919bed948dc2 Cong Wang 2022-06-15 1649 return copied; 04919bed948dc2 Cong Wang 2022-06-15 1650 } 04919bed948dc2 Cong Wang 2022-06-15 1651 EXPORT_SYMBOL(tcp_read_skb); 04919bed948dc2 Cong Wang 2022-06-15 1652 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
