Re: [PATCH bpf v2 1/3] samples/bpf: Add -fsanitize=bounds to userspace programs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 17, 2023 at 2:43 PM Jinghao Jia <jinghao7@xxxxxxxxxxxx> wrote:
>
> From: Jinghao Jia <jinghao@xxxxxxxxxxxxx>
>
> The sanitizer flag, which is supported by both clang and gcc, would make
> it easier to debug array index out-of-bounds problems in these programs.
>
> Suggested-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>
> Signed-off-by: Jinghao Jia <jinghao@xxxxxxxxxxxxx>
> Signed-off-by: Ruowen Qin <ruowenq2@xxxxxxxxxxxx>
> Signed-off-by: Jinghao Jia <jinghao7@xxxxxxxxxxxx>
> ---
>  samples/bpf/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
> index 4ccf4236031c..21d2edffce3c 100644
> --- a/samples/bpf/Makefile
> +++ b/samples/bpf/Makefile
> @@ -169,6 +169,7 @@ endif
>  TPROGS_CFLAGS += -Wall -O2
>  TPROGS_CFLAGS += -Wmissing-prototypes
>  TPROGS_CFLAGS += -Wstrict-prototypes
> +TPROGS_CFLAGS += -fsanitize=bounds

Patches 2 and 3 look great. Thanks for the fixes,
but this one is too aggressive to force on developers.
I think ubsan doesn't come by default in fedora gcc.
Could you make the makefile smarter and detect the presence
of ubsan in the compiler at build time?
I've applied patches 2 and 3 in the meantime.





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux