On Mon, Sep 18, 2023 at 6:54 AM Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > > > > > > > > > This might have been raised already, but bpf on x86 now depends on > > > CONFIG_UNWINDER_ORC ? > > > > > > $ grep CONFIG_UNWINDER_ORC .config > > > # CONFIG_UNWINDER_ORC is not set > > > > > > $ make ... > > > arch/x86/net/bpf_jit_comp.c:3022:58: error: no member named 'sp' in > > > 'struct unwind_state' > > > if (!addr || !consume_fn(cookie, (u64)addr, > > > (u64)state.sp, (u64)state.bp)) > > > ~~~~~ ^ > > > 1 error generated. > > > > Kumar, > > can probably explain better, > > but no the bpf as whole doesn't depend. > > One feature needs either ORC or frame unwinder. > > It won't work with unwinder_guess. > > The build error is a separate issue. > > It hasn't been reported before. > > I see the error with CONFIG_UNWINDER_FRAME_POINTER. > That's unexpected. > Kumar, > looks like this config path wasn't tested. > > Eric, Paolo, Dave, Kuba, > please ignore this PR. > We need to fix this first. Sorry, wifi is slow here. I didn't notice that it got merged and pw-bot didn't notice it either (no emails). We'll send another bpf-next PR with fixes right away. Sorry about the build breakage.
