On Fri, Sep 15, 2023 at 3:14 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote: > > Dan reported Smatch static checker warning due to missing error > value set in uprobe multi link's get_pid_task error path. > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Closes: https://lore.kernel.org/bpf/c5ffa7c0-6b06-40d5-aca2-63833b5cd9af@moroto.mountain/ > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx> Reviewed-by: Song Liu <song@xxxxxxxxxx> > --- > kernel/trace/bpf_trace.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c > index c1c1af63ced2..868008f56fec 100644 > --- a/kernel/trace/bpf_trace.c > +++ b/kernel/trace/bpf_trace.c > @@ -3223,8 +3223,10 @@ int bpf_uprobe_multi_link_attach(const union bpf_attr *attr, struct bpf_prog *pr > rcu_read_lock(); > task = get_pid_task(find_vpid(pid), PIDTYPE_PID); > rcu_read_unlock(); > - if (!task) > + if (!task) { > + err = -ESRCH; > goto error_path_put; > + } > } > > err = -ENOMEM; > -- > 2.41.0 > >
