On Wed, Sep 13, 2023 at 5:14 PM Puranjay Mohan <puranjay12@xxxxxxxxx> wrote: > > On Wed, Sep 13 2023, Kumar Kartikeya Dwivedi wrote: > > Hi, > > > Add selftests to cover success and failure cases of API usage, runtime > > behavior and invariants that need to be maintained for implementation > > correctness. > > > > Signed-off-by: Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx> > > --- > > tools/testing/selftests/bpf/DENYLIST.aarch64 | 1 + > > tools/testing/selftests/bpf/DENYLIST.s390x | 1 + > > .../selftests/bpf/prog_tests/exceptions.c | 408 ++++++++++++++++++ > > .../testing/selftests/bpf/progs/exceptions.c | 368 ++++++++++++++++ > > .../selftests/bpf/progs/exceptions_assert.c | 135 ++++++ > > .../selftests/bpf/progs/exceptions_ext.c | 72 ++++ > > .../selftests/bpf/progs/exceptions_fail.c | 347 +++++++++++++++ > > 7 files changed, 1332 insertions(+) > > create mode 100644 tools/testing/selftests/bpf/prog_tests/exceptions.c > > create mode 100644 tools/testing/selftests/bpf/progs/exceptions.c > > create mode 100644 tools/testing/selftests/bpf/progs/exceptions_assert.c > > create mode 100644 tools/testing/selftests/bpf/progs/exceptions_ext.c > > create mode 100644 tools/testing/selftests/bpf/progs/exceptions_fail.c > > > > diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64 > > index 7f768d335698..f5065576cae9 100644 > > --- a/tools/testing/selftests/bpf/DENYLIST.aarch64 > > +++ b/tools/testing/selftests/bpf/DENYLIST.aarch64 > > @@ -1,5 +1,6 @@ > > bpf_cookie/multi_kprobe_attach_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3 > > bpf_cookie/multi_kprobe_link_api # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3 > > +exceptions # JIT does not support calling kfunc bpf_throw: -524 > > I think you forgot to drop this. > exceptions work on aarch64 with this: https://lore.kernel.org/bpf/20230912233942.6734-1-puranjay12@xxxxxxxxx/ Sorry for the noise. I realised that my patch should remove this from the DENYLIST. > Thanks, > Puranjay
