So we've got a curious report recently: https://github.com/ClangBuiltLinux/linux/issues/1913 ld.lld: error: ld-temp.o <inline asm>:14577:1: symbol '__BTF_ID__struct__cgroup__624' is already defined __BTF_ID__struct__cgroup__624: ^ It's been hard to pin down a SHA and .config to reproduce this, but looking at the definition of BTF_ID's usage of __ID's usage of __COUNTER__, and the two statements: kernel/bpf/helpers.c:2460:BTF_ID(struct, cgroup) kernel/bpf/verifier.c:5075:BTF_ID(struct, cgroup) Is it possible that __COUNTER__ could evaluate to the same value across 2 different translation units, leading to a name collision like the above? looking at another usage of BTF_ID other than struct cgroup;kernel/bpf/helpers.c:2461:BTF_ID(func, bpf_cgroup_release) is only defined in one translation unit Should one of those two `BTF_ID(struct, cgroup)` be removed? Is there some other way we can avoid these collisions in the future? Was this a previously observed/fixed issue? -- Thanks, ~Nick Desaulniers
