Re: [PATCH bpf-next] selftests/bpf: Correct map_fd to data_fd in tailcalls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 6, 2023 at 1:50 PM Maciej Fijalkowski
<maciej.fijalkowski@xxxxxxxxx> wrote:
>
> On Wed, Sep 06, 2023 at 11:42:56PM +0800, Leon Hwang wrote:
> > Get and check data_fd. It should not check map_fd again.
> >
> > Meanwhile, correct some 'return' to 'goto out'.
> >
> > Thank the suggestion from Maciej in "bpf, x64: Fix tailcall infinite
> > loop"[0] discussions.
> >
> > [0] https://lore.kernel.org/bpf/e496aef8-1f80-0f8e-dcdd-25a8c300319a@xxxxxxxxx/T/#m7d3b601066ba66400d436b7e7579b2df4a101033
>
> in the subject of the patch you should have 'bpf', not 'bpf-next'.
>
> Fix this and send v2 please. You can also include my:

No need to resend just to tweak the subject.

Also this is not a fix that is worth sending to bpf tree.
Selftests are typically bpf-next.

> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>

Thanks





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux