On 29/08/2023 11:18, Daan De Meyer wrote:
> Add the necessary plumbing to hook up the new cgroup unix sockaddr
> hooks into bpftool.
>
> Signed-off-by: Daan De Meyer <daan.j.demeyer@xxxxxxxxx>
> ---
> .../bpftool/Documentation/bpftool-cgroup.rst | 21 ++++++++++++++-----
> .../bpftool/Documentation/bpftool-prog.rst | 10 +++++----
> tools/bpf/bpftool/bash-completion/bpftool | 14 ++++++-------
> tools/bpf/bpftool/cgroup.c | 17 ++++++++-------
> tools/bpf/bpftool/prog.c | 9 ++++----
> 5 files changed, 44 insertions(+), 27 deletions(-)
>
> diff --git a/tools/bpf/bpftool/Documentation/bpftool-cgroup.rst b/tools/bpf/bpftool/Documentation/bpftool-cgroup.rst
> index bd015ec9847b..a2d990fa623b 100644
> --- a/tools/bpf/bpftool/Documentation/bpftool-cgroup.rst
> +++ b/tools/bpf/bpftool/Documentation/bpftool-cgroup.rst
> @@ -34,13 +34,16 @@ CGROUP COMMANDS
> | *ATTACH_TYPE* := { **cgroup_inet_ingress** | **cgroup_inet_egress** |
> | **cgroup_inet_sock_create** | **cgroup_sock_ops** |
> | **cgroup_device** | **cgroup_inet4_bind** | **cgroup_inet6_bind** |
> -| **cgroup_inet4_post_bind** | **cgroup_inet6_post_bind** |
> -| **cgroup_inet4_connect** | **cgroup_inet6_connect** |
> +| **cgroup_unix_bind** | **cgroup_inet4_post_bind** |
> +| **cgroup_inet6_post_bind** | **cgroup_inet4_connect** |
> +| **cgroup_inet6_connect** | **cgroup_unix_connect** |
> | **cgroup_inet4_getpeername** | **cgroup_inet6_getpeername** |
> -| **cgroup_inet4_getsockname** | **cgroup_inet6_getsockname** |
> -| **cgroup_udp4_sendmsg** | **cgroup_udp6_sendmsg** |
> +| **cgroup_unix_getpeername** | **cgroup_inet4_getsockname** |
> +| **cgroup_inet6_getsockname** | **cgroup_udp4_sendmsg** |
Aren't we missing "cgroup_unix_getsockname" in this list?
Looks all good otherwise, thanks.
> +| **cgroup_udp6_sendmsg** | **cgroup_unix_sendmsg** |
> | **cgroup_udp4_recvmsg** | **cgroup_udp6_recvmsg** |
> -| **cgroup_sysctl** | **cgroup_getsockopt** | **cgroup_setsockopt** |
> +| **cgroup_unix_recvmsg** | **cgroup_sysctl** |
> +| **cgroup_getsockopt** | **cgroup_setsockopt** |
> | **cgroup_inet_sock_release** }
> | *ATTACH_FLAGS* := { **multi** | **override** }
