On 22/08/2023 16.22, Toke Høiland-Jørgensen wrote:
The functionality of these utilities have been incorporated into the xdp-bench utility in xdp-tools. Remove the unmaintained versions in samples.
I think it will be worth our time if we give some examples of how the removed utility translates to some given xdp-bench commands. There is not a 1-1 mapping. XDP driver changes need to be verified on physical NIC hardware, so these utilities are still being run by QA. I know Red Hat, Intel and Linaro QA people are using these utilities. It will save us time if we can reference a commit message instead of repeatable describing this. E.g. for Intel is it often contingent workers that adds a tested-by (that all need to update their knowledge). Red Hat is in the process of moving our QA to use xdp-bench / xdp-tools. Want to mention LNST team are also adding xdp-bench (+pktgen) support: - https://github.com/LNST-project/lnst/pull/310 --Jesper
Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> --- samples/bpf/Makefile | 7 -- samples/bpf/xdp1_kern.c | 100 ------------------------ samples/bpf/xdp1_user.c | 166 ---------------------------------------- samples/bpf/xdp2_kern.c | 125 ------------------------------ 4 files changed, 398 deletions(-) delete mode 100644 samples/bpf/xdp1_kern.c delete mode 100644 samples/bpf/xdp1_user.c delete mode 100644 samples/bpf/xdp2_kern.c
