On 8/21/23 1:03 PM, Oleg Nesterov wrote:
get_pid_task() makes no sense, the code does put_task_struct() soon after. Use find_task_by_pid_ns() instead of find_pid_ns + get_pid_task and kill kill put_task_struct(), this allows to do get_task_struct() only once
remove the duplicated 'kill' in the above.
before return. While at it, kill the unnecessary "if (!pid)" check in the "if (!*tid)" block, this matches the next usage of find_pid_ns() + get_pid_task() in this function. Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
LGTM. Acked-by: Yonghong Song <yonghong.song@xxxxxxxxx>
