Hi Steve, Can you review this series? I would like to push this to for-next. Thank you, On Mon, 7 Aug 2023 11:54:28 +0900 "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote: > Hi, > > Here is the 5th version of series to improve the BTF support on probe events. > The previous series is here: > > https://lore.kernel.org/all/169078860386.173706.3091034523220945605.stgit@devnote2/ > > This version introduces kernel/trace/trace_btf.c to separate the btf generic > functions. These functions will be moved to btf.c next merge window. > This fixes the member-search function to return the bit-offset of the > parent anonymous union/structure. Thus the caller can calculate the real > bit-offset from the root data structure. > This also fixes the ftrace selftest issue which fails if the kernel > supports only BTF args but not support field access. > > This series can be applied on top of "probes/core" branch of > https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git/ > > You can also get this series from: > > git://git.kernel.org/pub/scm/linux/kernel/git/mhiramat/linux.git topic/fprobe-event-ext > > Thank you, > > --- > > Masami Hiramatsu (Google) (9): > tracing/probes: Support BTF argument on module functions > tracing/probes: Move finding func-proto API and getting func-param API to trace_btf > tracing/probes: Add a function to search a member of a struct/union > tracing/probes: Support BTF based data structure field access > tracing/probes: Support BTF field access from $retval > tracing/probes: Add string type check with BTF > tracing/fprobe-event: Assume fprobe is a return event by $retval > selftests/ftrace: Add BTF fields access testcases > Documentation: tracing: Update fprobe event example with BTF field > > > Documentation/trace/fprobetrace.rst | 64 ++- > include/linux/btf.h | 1 > kernel/bpf/btf.c | 2 > kernel/trace/Makefile | 1 > kernel/trace/trace.c | 3 > kernel/trace/trace_btf.c | 109 ++++ > kernel/trace/trace_btf.h | 11 > kernel/trace/trace_eprobe.c | 4 > kernel/trace/trace_fprobe.c | 59 ++ > kernel/trace/trace_kprobe.c | 1 > kernel/trace/trace_probe.c | 499 +++++++++++++++----- > kernel/trace/trace_probe.h | 27 + > kernel/trace/trace_uprobe.c | 1 > .../ftrace/test.d/dynevent/add_remove_btfarg.tc | 20 + > .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc | 10 > 15 files changed, 637 insertions(+), 175 deletions(-) > create mode 100644 kernel/trace/trace_btf.c > create mode 100644 kernel/trace/trace_btf.h > > -- > Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> -- Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>