On 2023/8/19 11:10, Eric Dumazet wrote: > On Sat, Aug 19, 2023 at 3:52 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: >> >> On Sat, 12 Aug 2023 20:12:50 +0000 Zheao Li wrote: >>> In normal use case, the tcp_ca_event would be changed in high frequency. >>> >>> The developer can monitor the network quality more easier by tracing >>> TCP stack with this TP event. >>> >>> So I propose to add a `tcp:tcp_ca_event` trace event >>> like `tcp:tcp_cong_state_set` to help the people to >>> trace the TCP connection status >> >> Ah, I completely missed v3 somehow and we got no ack from Eric so maybe >> he missed it, too. Could you please resend not as part of this thread >> but as a new thread? > > I was waiting for a v4, because Steven asked for additional spaces in the macros > for readability ? I think the additional spaces should not be added in this patch. Because there will be two code style in one file. I think it would be a good idea for another patch to adjust the space in this file