On 8/15/23 05:24, Yunsheng Lin wrote: > On 2023/8/15 6:42, Randy Dunlap wrote: >> Hi-- > Thanks for the reviewing. > > ... > >>> @@ -100,6 +115,14 @@ static inline struct page *page_pool_alloc_frag(struct page_pool *pool, >>> return __page_pool_alloc_frag(pool, offset, size, gfp); >>> } >>> +/** >>> + * page_pool_dev_alloc_frag() - allocate a page frag. >>> + * @pool[in] pool from which to allocate >>> + * @offset[out] offset to the allocated page >>> + * @size[in] requested size >> Please use kernel-doc syntax/notation here. > Will change to: Thanks. Those look good. -- ~Randy