On Mon, Aug 14, 2023 at 4:16 AM Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx> wrote: > > On Wed, Aug 09, 2023 at 09:54:09AM -0700, Stanislav Fomichev wrote: > > This series implements initial TX metadata (offloads) for AF_XDP. > > See patch #2 for the main implementation and mlx5-one for the > > example on how to consume the metadata on the device side. > > > > Starting with two types of offloads: > > - request TX timestamp (and write it back into the metadata area) > > - request TX checksum offload > > > > Changes since last RFC: > > - add /* private: */ comments to headers (Simon) > > - handle metadata only in the first frag (Simon) > > - rename xdp_hw_metadata flags (Willem) > > - s/tmo_request_checksum/tmo_request_timestamp/ in xdp_metadata_ops > > comment (Willem) > > - Documentation/networking/xsk-tx-metadata.rst > > Stan, > > thanks for working on it - we reviewed the patchset with Magnus and we > have some questions (responded inline to patches). Overall we think it > would be worth implementing this work against another ZC driver > (preferably ice :P) to check that proposed API is generic enough. Awesome, thanks for the review! I can try to see if I have some ice-capable hw around, but if you want to help with the ice implementation I'd gladly accept the offer :-p