On Fri, 2023-08-11 at 14:01 +0200, Jose E. Marchesi wrote: > > On Thu, 2023-08-10 at 21:10 +0200, Jose E. Marchesi wrote: > > [...] > > > Note the same fix would be needed in the inline asm in > > > selftests/bpf/progs/iters.c:iter_err_unsafe_asm_loop. > > > > Right, sorry. Tested with that change as well, no changes in the > > generated object files for clang. Can't grep "p" anywhere else in > > selftests. > > > > [...] > > Thank you. > > Ok, so since people seems to agree to the proposed fix, I will prepare a > patch for this. First I will have to set up a kernel BPF development > environment... but I guess it is about time for that ;) > > Other than running the kernel selftests, is there any other testing you > would recommend to a n00b like me, for changes like this (code > generation changes)? What I do is run same kernel selftests as CI: - test_verifier - test_progs - test_progs-no_alu32 - test_progs-cpuv4 Do you need any help with the environment itself? (I can describe my setup if you need that).
