> On 8/9/23 11:25 PM, Ziyang Xuan wrote: >> When use bpf_skb_adjust_room() to encapsulate or decapsulate packet, >> and outer protocol changed, we can update h_proto of ethhdr directly. > > This could break some existing bpf programs. e.g what if the existing prog is testing the h_proto after bpf_skb_adjust_room() and expect it hasn't changed yet? > I think some new modifications break some existing things are not unacceptable. Maybe my modification is inappropriate because its benefits are small and some kind of principle is broken, such as Yonghong Song pointed: "bpf_skb_adjust_room() only changes skb meta data and tries not to modify the packet." If it is, the modification should be rejected. Thank you! William Xuan > > .
